fix: SG-35309: Remove OCIO output when set to active with env variable unset#1263
Open
deltag0 wants to merge 6 commits into
Open
fix: SG-35309: Remove OCIO output when set to active with env variable unset#1263deltag0 wants to merge 6 commits into
deltag0 wants to merge 6 commits into
Conversation
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
deltag0
force-pushed
the
OCIO-environment-variable-output-fix
branch
from
394d400 to
77ffaa4
Compare
deltag0
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Remove OCIO output when set to active with env variable unset
Summarize your change.
When a user loads a valid OCIO config after opening a file and sets the OCIO as an active display with the environment variable
OCIOnot set, there used to be an error log. The error log is now and the environment variable is set after selecting a config.Moreover, the config path is saved to user preferences after choosing it.
Describe the reason for the change.
Redundant error logs and console pop ups because once the user loads the OCIO config with no environment variable there's already an error log.
Describe what you have tested and on which operating system.
Tested on Mac CY2025
Add a list of changes, and note any that might need special attention during the review.
N/A
If possible, provide screenshots.